Skip to content

Conversation

dsaxton
Copy link
Contributor

@dsaxton dsaxton commented May 6, 2020

cc @simonjayhawkins

xref #25744 #34020

I think the dtype issue for DataFrame.update with categorical columns mentioned in the first issue is still unaddressed, so likely don't want to only close and lose that (perhaps break into its own issue)?

@simonjayhawkins simonjayhawkins added ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite labels May 6, 2020
@simonjayhawkins
Copy link
Member

I think the dtype issue for DataFrame.update with categorical columns mentioned in the first issue is still unaddressed, so likely don't want to only close and lose that (perhaps break into its own issue)?

sgtm.

although this PR could close the 2 issues (with the caveat of opening a new issue for the DataFrame case), my preference would be to replace test_update_extension_array_series with a test in tests/extension instead.

@dsaxton
Copy link
Contributor Author

dsaxton commented May 9, 2020

my preference would be to replace test_update_extension_array_series with a test in tests/extension instead.

I think this is okay since it's the Series update method that we're testing? TBH the extension-specific tests are a bit confusing to me because of the class hierarchies and heavy use of fixtures (IMHO it's easier if we can reason about tests locally)

@jreback jreback added this to the 1.1 milestone May 10, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. ping on green.

@dsaxton
Copy link
Contributor Author

dsaxton commented May 10, 2020

lgtm. ping on green.

@jreback ping

@jreback jreback merged commit 1818c28 into pandas-dev:master May 10, 2020
@jreback
Copy link
Contributor

jreback commented May 10, 2020

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants